search

onlook-dev / onlook

The open source, local-first Figma for React. Design directly in your live React app and publish your changes to code.
https://onlook.dev
Apache License 2.0
3.13k stars 198 forks source link

[bug] "Onlook is not enabled" -> "Learn how to enable" invalid link #303

Closed mikegreen closed 1 month ago

mikegreen commented 1 month ago

Describe the bug

Small, but figured it'd be good to know how to enable if/when this exists?

Clicking the "Learn how to enable" link in the app takes you to: https://github.com/onlook-dev/onlook?tab=readme-ov-file#using-your-own-react-project Which does not seem to exist.

image
Kitenite commented 1 month ago

Thanks for the catch @mikegreen! We moved that link to this wiki here. I will add a bug fix for this :)

ScubyG commented 1 month ago

@Kitenite, you beat me to updating this issue. I wasn't sure sure if it requires a direct link to the anchor in the article or if the link is was for general documentation.

Kitenite commented 1 month ago

@ScubyG could you do the wiki link? I just saw the PR, you work fast!

mikegreen commented 1 month ago

Great, thanks folks. Happy to see NextJS in there, starting a new platform and wanted to see how a greenfield project plays in.

ScubyG commented 1 month ago

Yes, of course. I will have a look at the app this evening and see if I can find any more issues. I saw the issue on my phone so had to boot up and log in to my trusty old thinkpad which is why I couldn't get to it quicker :)

@ScubyG could you do the wiki link? I just saw the PR, you work fast!

Yes, of course. I will have a look at the app this evening and see if I can find any more issues. I saw the issue on my phone so had to boot up and log in to my trusty old thinkpad which is why I couldn't get to it quicker :)

Kitenite commented 1 month ago

Glad to know Onlook runs on the ol' thinkpad! @ScubyG

Kitenite commented 1 month ago

Fixed by @ScubyG! Let me know if you run into any more issues @mikegreen