search

onlook-dev / onlook

The open source, local-first Figma for React. Design directly in your live React app and publish your changes to code.
https://onlook.dev
Apache License 2.0
2.85k stars 175 forks source link

[feat] Allow the window size to be changed while in Interact Mode #486

Open drfarrell opened 1 week ago

drfarrell commented 1 week ago

Essentially let these handles be usable while in Interact mode.

Screenshot 2024-10-09 at 12 15 21 AM
sahil-1729 commented 1 week ago

I want to work on this issue, can you assign it to me?

Kitenite commented 1 week ago

Go for it! It's being hidden right now here. I'm not sure there's adverse effect in removing it so some testing to ensure expected behavior might be warrented https://github.com/onlook-dev/onlook/blob/983c7907fe42f626ea58148fb1c7228e7f4e95d5/app/src/routes/editor/WebviewArea/ResizeHandles.tsx#L61

sahil-1729 commented 1 week ago

I’ve fixed the issue, and it’s working on my local machine. I’m ready to add tests, could you point me in the right direction on where to add test in the repo? Should I add them in the test folder here, or is there a other folder I should follow?

Kitenite commented 6 days ago

Hey @sahil-1729, We don't have UI tests yet. Though we really need them. Feel free to open the PR. If you'd like to add UI tests, that would be a really good separate task!

Kitenite commented 2 days ago

Also keeping in mind that if dragging quickly, the resize can be buggy because the inreact window catches mouse event. This needs to be handled as well :)