search

onlook-dev / onlook

The open source, local-first Figma for React. Design directly in your live React app and publish your changes to code.
https://onlook.dev
Apache License 2.0
2.84k stars 172 forks source link

[feat] Rename project from the project menu in the editor #551

Open drfarrell opened 2 days ago

drfarrell commented 2 days ago

Two parts, part 1 is for beginners, and part 2 is more intermediate.

  1. Add in an item here that allows the user to reliably rename their project just like they can on the projects view. #515
  2. Allow the user to double-click a project name and rename it as if it were an input. Use the initial project name as a placeholder text. If the user hits enter, save the name. If the user his ESC, cancel the name change.
image
sambhavnrana commented 2 days ago

Would like to work on it @drfarrell

Kitenite commented 2 days ago

Go for it @sambhavnrana !

sambhavnrana commented 9 hours ago

Issue #515: Project Renaming Functionality The current implementation of the project renaming feature has some limitations:

Local Device Name Change: Renaming a project only updates the name in the desktop application, and does not change the name locally on the device. Deletion Behaviour: When a project is deleted from the application, it does not remove the project from the device.

To enhance user experience, should I focus on addressing these issues first, or should I continue working on assigned features only ?

Kitenite commented 34 minutes ago

Hey @sambhavnrana ,

The current behavior is acceptable for now. We want to scope the name changes to only the app for users who are importing an existing project. Deleting or renaming their project folder would be unexpected behavior.

We may introduce explicit filesystem rename and delete later down the line. I like the user-centric line of thinking though :)