search

onlook-dev / onlook

The open source, local-first Figma for React. Design directly in your live React app and publish your changes to code.
https://onlook.dev
Apache License 2.0
3.84k stars 237 forks source link

[feat] Move "Onlook is not enabled" to the editor topbar #636

Open drfarrell opened 1 month ago

drfarrell commented 1 month ago

We need to make more room in the top navigation bar of the window, so I'd like a button to appear in place of the "changes" number when the project is not properly setup with Onlook.

The original design: image where the indicator for whether something was enable or not used to live in the topbar of the browser

image

The new update design: image

This would likely mean putting the changes indicator into a div, Wrapping that div with a flex-row, adding in the Onlook warning, and then doing a conditional to show the warning when a project is not connected.

guidopola commented 1 month ago

Hello! I'd like to work on this, can I get this assigned to me?

drfarrell commented 1 month ago

Hey @guidopola Sorry I still need to refine the design on this... are there any other issues I can assign to you? We have some other things we just need this design to handle that I didn't take into consideration.

guidopola commented 1 month ago

Hey @drfarrell sorry for late reply, for some reason github didn't notify me.

Sure, feel free to assign me to another issues.