onlook-dev / onlook

The open source, local-first Figma for React. Design directly in your live React app and publish your changes to code.
https://onlook.dev
Apache License 2.0
3.75k stars 233 forks source link

shared tsconfig #694

Closed hitaspdotnet closed 3 weeks ago

hitaspdotnet commented 3 weeks ago

Description

Shared TS configs for bun compiler

What is the purpose of this pull request?

Kitenite commented 3 weeks ago

Hanging on bun run build at root for me. Hanging really at @onlook/studio

❯ bun run build
$ bun --filter '*' build
@onlook/foundation build $ tsup
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [1 lines elided]
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [2 lines elided]
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [3 lines elided]
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
│ DTS ⚡️ Build success in 966ms
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [5 lines elided]
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
│ DTS ⚡️ Build success in 966ms
│ DTS dist/index.d.mts 1.08 KB
│ DTS dist/index.d.ts  1.08 KB
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [5 lines elided]
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
│ DTS ⚡️ Build success in 966ms
│ DTS dist/index.d.mts 1.08 KB
│ DTS dist/index.d.ts  1.08 KB
└─ Done in 1.33 s
onlook build $ esbuild src/index.ts --bundle --platform=node --format=cjs --outfile=dist/index.cjs
│ 
│   dist/index.cjs  2.4mb ⚠️
│ 
│ ⚡ Done in 35ms
└─ Done in 42 ms
@onlook/studio build $ tsc && vite build
└─ Running...
Kitenite commented 3 weeks ago

Looks like the vite command is what is hanging. Same with bun run dev. Potentially is failing silently. bun run clean before didn't help.

Kitenite commented 3 weeks ago

The build issue stemmed from .js files being generated (not sure when that happened). Stashing those files and building worked. No regressions found.