onlxltd / bonjour-service

A Bonjour/Zeroconf protocol implementation in TypeScript
https://npmjs.com/package/bonjour-service
MIT License
64 stars 20 forks source link

Bonjour constructor options type does not match mDNS options type (missing interface field) #52

Open JensEggers opened 2 weeks ago

JensEggers commented 2 weeks ago

mDNS can be bound to a specified network interface via the interface property in its Options type (see https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/multicast-dns/index.d.ts#L58). This field is not present in the ServiceConfig type, and so we're not able to bind Bonjour to a particular adapter.

This could be fixed in one of two ways:

JensEggers commented 1 week ago

it turns out that Node.js doesn't appear to receive multicast messages on UDP sockets bound to particular adapters, so the need to specify an adapter becomes irrelevant. This issue can probably close for that reason.