onlydustxyz / marketplace-api

2 stars 2 forks source link

Remove BO API Key #751

Closed AnthonyBuisset closed 1 month ago

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9993955](https://dashboard.gitguardian.com/workspace/367108/incidents/9993955?occurrence=142431633) | Triggered | Generic High Entropy Secret | bcb6faee466469c1ea02eedf351493f7f79b9c2d | .env.example | [View secret](https://github.com/onlydustxyz/marketplace-api/commit/bcb6faee466469c1ea02eedf351493f7f79b9c2d#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cL15) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.74%. Comparing base (81afff2) to head (cafff99). Report is 72 commits behind head on main.

:exclamation: Current head cafff99 differs from pull request most recent head bcb6fae

Please upload reports for the commit bcb6fae to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ============================================ + Coverage 85.71% 85.74% +0.03% - Complexity 3218 3288 +70 ============================================ Files 490 500 +10 Lines 11306 11414 +108 Branches 856 878 +22 ============================================ + Hits 9691 9787 +96 + Misses 936 934 -2 - Partials 679 693 +14 ``` | [Flag](https://app.codecov.io/gh/onlydustxyz/marketplace-api/pull/751/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onlydustxyz) | Coverage Δ | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/onlydustxyz/marketplace-api/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onlydustxyz) | `85.74% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onlydustxyz#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.