search

onlydustxyz / marketplace-indexer

Index data from Github
2 stars 2 forks source link

This is a good first issue #172

Open ofux opened 1 month ago

ofux commented 1 month ago

Torii engine is in charge of pulling the events and processing each one of them using the corresponding processor.

More tests have to be added to ensure the modifications made to the engine and processors are correctly done.

The engine is here: https://github.com/dojoengine/dojo/blob/22072dd62792fd3625d5c02c1f10254b6b10f9f5/crates/torii/core/src/engine.rs The processors are here: https://github.com/dojoengine/dojo/blob/22072dd62792fd3625d5c02c1f10254b6b10f9f5/crates/torii/core/src/processors/mod.rs

Two approaches to write those tests:

Mocking: by not using any underlying node, all processors can first be tested with mocked events, constructed by end, to ensure we can extract correctly the information for a well formatted event. To test the logic around the event fetching and pagination, the starknet provider can also be mocked, or Katana test runner may be use. This issue can be tackled in two PR if necessary.

ofux commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

yoooooo

How I plan on tackling this issue

yooooo

ScottyDavies commented 1 month ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

As an experienced analyst and blockchain developer with 15 years in the industry. i likely encountered a variety of challenges that these technologies can help address. My technical expertise and problem-solving skills will be valuable assets in leveraging Java.

How I plan on tackling this issue

To solve this issue, we can take a two-pronged approach:

Mocking-based Testing: Create unit tests for the processors by mocking events and ensuring the processors correctly extract the necessary information. Mock the Starknet provider or use the Katana test runner to test the logic around event fetching and pagination. This allows testing the processor logic in isolation. Integration Testing: Create integration tests that exercise the full Torii engine functionality, including the interaction between the engine and processors. Use real event data from a test Starknet node or recorded event data to ensure the engine and processors work correctly with real-world data. This helps catch issues arising from the engine-processor interaction and ensures the overall system functions as expected.

mohit-100 commented 1 week ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a MERN stack developer with a strong focus on React development and experience in building scalable web and mobile applications. My work on various projects, including e-commerce platforms and LMS systems, has honed my skills in both front-end and back-end technologies. I am proficient in Node.js, Express.js, AWS serverless, and Docker CI/CD, with a growing interest in blockchain technology. My ability to deliver comprehensive solutions makes me a strong fit for innovative projects that require a blend of technical expertise and creativity.

How I plan on tackling this issue

My approach to problem-solving begins with thoroughly understanding the problem, clarifying any unclear requirements, and identifying constraints. I then break the problem into smaller, manageable components, prioritizing tasks based on impact. After researching and exploring potential solutions, I choose the best approach, often starting with a prototype. I iterate and refine the solution based on feedback and thorough testing. Finally, I ensure that the process is well-documented for future reference and continuous improvement.