search

onlydustxyz / starklings

An interactive tutorial to get you up and running with Starknet
309 stars 83 forks source link

Update to Cairo-lang 0.8.2 #126

Open Bernardstanislas opened 2 years ago

Bernardstanislas commented 2 years ago

Starkware has released a new version of the Cairo lang, version 0.8.2, we might want to update our dependency/exercises.

Codiumdium commented 2 years ago

Hi! I can try to do it. Any tips ?

Bernardstanislas commented 2 years ago

I have nothing special in mind, maybe going from the changelog would be a good start, or the announcements in the Starknet discord?

Codiumdium commented 2 years ago

So protostar is at v0.2.3 and it needs Cairo v0.9.0. So I need to update pyproject.toml and i think i need to build starklings-protostar but i did not find its github and the script that builds it and the PyPi project.

Bernardstanislas commented 2 years ago

Hum that's because I manually published it on my side, I will check if my fork can be updated. I discussed with the Protostar team in the past to help them publish the package but it was not a priority/need for them

Codiumdium commented 2 years ago

Ok. So we can create a Github repository for that ? I think it makes it easier to update.

Bernardstanislas commented 2 years ago

Sure!

Codiumdium commented 2 years ago

Ok. I will create it.

Codiumdium commented 2 years ago

Hi! I am working on this. I want to update pyproject.toml like that:

[tool.poetry.dependencies]
cairo-lang = "^0.9.0"
protostar = {url = "https://github.com/software-mansion/protostar/archive/refs/tags/v0.2.3.zip"}

but I want to know why you made a python package for protonstart Did I miss something?

Bernardstanislas commented 2 years ago

Back in the time we had to publish protostar because it was not usable as you describe, since the main folder was named src, you could not simply import protostar. I changed this in this PR https://github.com/software-mansion/protostar/pull/265 So I guess now it works the way you describe, and it's better than what we have now!