search

onlylemi / MapView

A MapView on Android platform.
MIT License
678 stars 162 forks source link

Multiple code improvements - squid:S1197, squid:S1854, squid:S1481, squid:S1155, squid:S2131 #2

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1197 - Array designators "[]" should be on the type, not the variable. squid:S1854 - Dead stores should be removed. squid:S1481 - Unused local variables should be removed. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S2131 - Primitives should not be boxed just for "String" conversion. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1197 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S2131 Please let me know if you have any questions. George Kankava

onlylemi commented 8 years ago

@georgekankava Thank you. This branch has conflicts, then I merge it in local and push it master.