onlyutkarsh / gitlab-integration

This extension integrates GitLab with Azure Pipelines. With this extension, you will be able to download the sources from a GitLab repository (using clone command) and use downloaded sources in Azure Pipelines
https://marketplace.visualstudio.com/items?itemName=onlyutkarsh.gitlab-integration
GNU General Public License v3.0
20 stars 5 forks source link

Unable to fetch version in `create a new release` if artifact was created using `Latest from default branch` for `default version` property #6

Closed amjn closed 5 years ago

amjn commented 5 years ago

Bug: Unable to fetch version in create a new release if artifact was created using Latest from default branch for default version property.

Repo Steps:

  1. Install the Gitlab extension and create a new server connection.
  2. Create an artifact for a Release and use Latest from default branch as Default version. Save your changes
  3. Click on Create a Release button and under Artifacts, we won't be able to fetch version for the Source alias

Reason behind Bug: Code passes invalid params to REST API under CommitsFromSelectedBranch. Here, we even if branch is empty we are passing query param ref_name.

Resolution: Do not pass ref_name if the branch is empty.

onlyutkarsh commented 5 years ago

Good find. I will test it out and merge. Thanks @jainamanjain