onmyway133 / Arcane

:trident: CommonCrypto in Swift, and more
https://onmyway133.github.io/
Other
283 stars 22 forks source link

Xcode 10, Swift 4.2 update #20

Closed radianttap closed 6 years ago

radianttap commented 6 years ago

In iOS 12 SDK, CommonCrypto is finally available.

This PR implements the approach explained in this SO answer. It use pre-compile scripts phase to check if CommonCrypto is available and if yes (on iOS 12) it does nothing. On earlier version it automatically creates CommonCrypto module map.

Tested with Xcode 9.4.1 & Swift 4.1, both standalone and as a CocoaPod.

Also tested in Xcode 10, with Swift 4.2. Podspec is updated to somewhat enforce Swift 4.2, but when built in Xcode 9 it correctly uses 4.1 in the Pods project's target.

onmyway133 commented 6 years ago

@radianttap You are the best 🚀