search

onmyway133 / DeepDiff

🦀Amazingly incredible extraordinary lightning fast diffing in Swift
https://onmyway133.com/apps/
Other
2.05k stars 145 forks source link

Need more public API #11

Closed nixzhu closed 6 years ago

nixzhu commented 6 years ago

I have try to make extension for ASTableNode & ASCollectionNode (both from ASDK) with DeepDiff. So the ChangeWithIndexPath, IndexPathConverter & Array.executeIfPresent need to be public.

Could you make it happen?

onmyway133 commented 6 years ago

@nixzhu Hi, it seems this PR matches your requirement https://github.com/onmyway133/DeepDiff/pull/10. I'm working on to make sure it's good to merge

nixzhu commented 6 years ago

@onmyway133 Thank you! I'll wait for it merged.

onmyway133 commented 6 years ago

@nixzhu I just merge this https://github.com/onmyway133/DeepDiff/pull/10. Can you check master to see if it works for you?

nixzhu commented 6 years ago

@onmyway133 It works for me. Thank you!

onmyway133 commented 6 years ago

@nixzhu I will try to make new release soon

onmyway133 commented 6 years ago

@nixzhu Hi, sorry for being late. Here is the new release with Swift 4.1 https://github.com/onmyway133/DeepDiff/releases/tag/1.2.0

nixzhu commented 6 years ago

@onmyway133 Thank you!

SolorzanoJose commented 5 years ago

@nixzhu how did you write this extension?