search

onmyway133 / DeepDiff

🦀Amazingly incredible extraordinary lightning fast diffing in Swift
https://onmyway133.com/apps/
Other
2.05k stars 143 forks source link

Build Library For Distribution (swift compatibility) #51

Closed cgmaier closed 5 years ago

cgmaier commented 5 years ago

hi! wondering if you'd be able to set the Build Libraries For Distribution flag to YES in the project's build settings. i use deep diff through Carthage and this would help to ensure support for new swift versions which seem to come with every new xcode release.

thank you !

github-actions[bot] commented 5 years ago

Message that will be displayed on users' first issue

cgmaier commented 5 years ago

hey @onmyway133 any update on this ? it's quite an easy but important improvement which will really help myself and future devs ! I'm hoping not to have to fork.

onmyway133 commented 5 years ago

@cgmaier ja, thanks for the suggestion. If you can make a PR for it ?

cgmaier commented 5 years ago

@onmyway133 done!

cgmaier commented 5 years ago

hey @onmyway133 let me know what ya think : )

cgmaier commented 5 years ago

thanks for merging the PR @onmyway133 ! a new release with this change would be great :)

onmyway133 commented 5 years ago

@cgmaier Hi, sorry for delay. I just made https://github.com/onmyway133/DeepDiff/releases/tag/2.3.1, and thanks for using DeepDiff, I love Giphy too

cgmaier commented 5 years ago

you're my hero!! thank u @onmyway133