Fixed formatting of content.json

onmyway133 / IconGenerator

🍱 A macOS app to generate app icons

https://onmyway133.com/

Other

1.41k stars 83 forks source link

Fixed formatting of content.json #3

Closed mofneko closed 6 years ago

mofneko commented 6 years ago

Overview Fixed a problem that the content.json was not well shaped and a large amount of difference was generated when replacing it with a genuine AppIcon

Details Although content.json for INDEX exists inside AppIcon, shaping is insufficient as compared with the original one, so a lot of git difference will be generated I think it is a minor fix that many people would not need readability, but for me it is important for future maintenance so I will send you this fix

onmyway133 commented 6 years ago

@mofneko Thanks for the PR. It makes sense. I added a small comment

mofneko commented 6 years ago

i fix it. thanks!

onmyway133 commented 6 years ago

@mofneko Hi, thanks for the PR. Unfortunately I can't make new release because of this https://github.com/electron-userland/electron-packager/issues/787. Hope it get resolved soon

mofneko commented 6 years ago

@onmyway133 Hi, thanks for fix it. https://github.com/onmyway133/IconGenerator/commit/b84e5d8dbe9b6d81c56c14d2440bc866856269c7#diff-e554ca4cf0b40fba42645d785ee7aeb1R36 i hope so.