onmyway133 / IconGenerator

🍱 A macOS app to generate app icons
https://onmyway133.com/
Other
1.41k stars 83 forks source link

Issue with tvOS #8

Closed hadihashem closed 5 years ago

hadihashem commented 6 years ago

Hello @onmyway133 I'm facing an issue trying to generate tvOS icons from this file example I get an empty Assets forlder It is working well however with the other types iOS and macOS Please advise Regards

onmyway133 commented 6 years ago

@hadihashem Hi, thanks for reporting, I will check

hadihashem commented 6 years ago

Hi @onmyway133 After investigation, the file Contents.json doesn't contain any dimension specification about tvOS And also, within the file Generator.js 2018-08-12_142439

onmyway133 commented 6 years ago

@hadihashem Hi, do you use Xcode 9 or Xcode 10? The template I'm using now is from Xcode 9, see my Generator https://github.com/onmyway133/IconGenerator/blob/master/library/Generator.js

hadihashem commented 6 years ago

Hi @onmyway133 I'm using Xcode 9 but as mentionned earlier, the current template is not tvOS ready

onmyway133 commented 6 years ago

@hadihashem Hi, it was my intention. tvOS app icons differ from iOS and macOS in that it has many kinds of icons. How do you want IconGenerator to support it?

tv

hadihashem commented 6 years ago

@onmyway133 there are solutions for everything but if this feature is not included in the Application today then I would suggest to take off the tvOS option from the GUI It is confusing otherwise 2018-08-16_070541

onmyway133 commented 5 years ago

@hadihashem Hi, I will remove tvOS support for now