search

onmyway133 / PushNotifications

🐉 A macOS, Linux, Windows app to test push notifications on iOS and Android
https://onmyway133.com
Other
2.26k stars 176 forks source link

Adding ability to set apns-collapse-id to iOS notifications #22

Closed Ariandr closed 4 years ago

Ariandr commented 4 years ago

Hi @onmyway133 I implemented the ability to set apns-collapse-id to the notification header. Manually tested, works okay. Solves the issue https://github.com/onmyway133/PushNotifications/issues/16

Also, just bumped the version to 1.6.0 and updated the description of the app.

Also fixed https://github.com/onmyway133/PushNotifications/issues/4 (selecting last chosen auth method for iOS)

Also fixed https://github.com/onmyway133/PushNotifications/issues/15. You initially fixed it, but there was no return keyword in catch block, so the request was sent with wrong parameters and Success message was displayed. Now it just doesn't send the request at all and displays the error message. E.g., Failed: SyntaxError: Unexpected end of JSON input

Screen Shot 2019-08-28 at 19 41 44
onmyway133 commented 4 years ago

@Ariandr Awesome 💪

Ariandr commented 4 years ago

@onmyway133 If you think that everything is okay, you can merge the request and create a new release 1.6.0. I will attach build artifacts to it 🙂

onmyway133 commented 4 years ago

@Ariandr ja, here it is https://github.com/onmyway133/PushNotifications/releases/tag/1.6.0

Ariandr commented 4 years ago

Hi @onmyway133 There was a request to update the App Store version of the app to version 1.6.0. I had a conversation with a user here: https://github.com/onmyway133/PushNotifications/issues/23