Add support for `apns-push-type` which is required for delivering iOS 13 notifications

onmyway133 / PushNotifications

🐉 A macOS, Linux, Windows app to test push notifications on iOS and Android

https://onmyway133.com

Other

2.26k stars 176 forks source link

Add support for `apns-push-type` which is required for delivering iOS 13 notifications #25

Closed Ariandr closed 4 years ago

Ariandr commented 4 years ago

Hi @onmyway133 I updated apn to v.3.0.0 (not npm version for now, https://github.com/node-apn/node-apn/releases).

It includes support for setting apns-push-type which is required for sending notifications to devices running iOS 13. I explained the necessity in the comments around code changes. Also, I tested it manually.

Please, have a look. We need to release it, because iOS 13 is coming in several days. I will attach build artifacts.

onmyway133 commented 4 years ago

@Ariandr Hi, I read through, look good to me. This project is getting popular, I'm thinking of restructuring it to use proper state and also JSX

Ariandr commented 4 years ago

@onmyway133 Yes, the project is getting lots of stars 🙂 It's a good idea to restructure it.

Anyway, you can create a new release with this PR, I will add build artifacts.

Ariandr commented 4 years ago

@onmyway133 Never mind, I created a release myself 🙂