onmyway133 / PushNotifications

🐉 A macOS, Linux, Windows app to test push notifications on iOS and Android
https://onmyway133.com
Other
2.26k stars 175 forks source link

Fix voip push #32

Closed atsushi-ageet closed 4 years ago

atsushi-ageet commented 4 years ago

voip push (Sandbox Environment) seems to fail. Set apns-push-type to voip if voip push.

see: https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns/

Ariandr commented 4 years ago

Hi @atsushi-ageet Thanks for your PR. Apple finally updated their documentation describing all possible apns-push-type values.

Have you done any testing of this change on your side?

atsushi-ageet commented 4 years ago

Hi @Ariandr

Have you done any testing of this change on your side?

Yes, I confirmed that my iPhone can actually receive voip push(Production & Sandbox).

Ariandr commented 4 years ago

@atsushi-ageet Great! Then I will create a new release with your PR. But also I want to add complication and fileprovider cases just in case someone needs it.