Closed Ariandr closed 5 years ago
@Ariandr 3465 file changes 😅 looks fine to me. Thanks for the PR 🚀
@onmyway133
I just updated dependencies and modified package.json
😀
@onmyway133 By the way, I think it's important to update the description of the project (now it includes support for Windows & Linux) and add new release with installers for Linux and Windows 🙂
@onmyway133
Also, it's probably fixes the issue #5 , because I updated electron
to the latest version.
@Ariandr Hi, I just released 1.3.0 https://github.com/onmyway133/PushNotifications/releases/tag/1.3.0
@onmyway133 Will you add installers v.1.3.0 for Windows and Linux platforms to the release description, if I provide you with them? I have just built v.1.3.0 for Windows and Linux.
@Ariandr Hi, I have another idea. Would you like to be contributor in this project? There you can manage releases, and we can collaborate together
@onmyway133 Yes. It sounds great. I'd like to become a contributor 🙂 I don't have any experience in managing releases on Github, but I think I will work it out))
@Ariandr Check your email 😉 . Don't worry, that's how we grow 💪
@onmyway133 Thanks, I've accepted.🙂
@onmyway133 I updated the release with installers of Windows and Linux apps. Also, I updated README. But it seems I don't have an access to update the repository description. Can you update it? 🙂
@Ariandr Cool. I updated the description too
@onmyway133 Great!
@Ariandr Hi, how did you generate builds for Linux and Windows? I run npm run dist
and it generates for macOS only
@onmyway133 You need to run that command on Windows and Linux machines separately 🙂 I have an old Windows laptop at work and for Linux I used a cloud service for building.
@onmyway133 Also I made sure that the node & npm versions were the same on all the platforms.
To build the Mac version, you will just need to run
npm run dist
on your mac, which will create adist
directory with build files and the app.Here is the link to .zip with Windows and Linux built versions/installers of the app. https://drive.google.com/file/d/1K1og5oMmh79iLEvy1dp2mc8vvfmdCbAX/view?usp=sharing