onmyway133 / PushNotifications

🐉 A macOS, Linux, Windows app to test push notifications on iOS and Android
https://onmyway133.com
Other
2.26k stars 176 forks source link

The app's window after launching the app is blank (1.3.0) #8

Closed Ariandr closed 5 years ago

Ariandr commented 5 years ago

It seems the new release has the old issue. Then I cloned the repository and built it to make sure, got the same problem. I will try to solve it. If I'm successful, I'll let you know.

screen shot 2018-08-16 at 11 58 01

onmyway133 commented 5 years ago

@Ariandr Hi, I updated electron and used npm run dist of electron-builder. Let me research further

Ariandr commented 5 years ago

@onmyway133 I'm not sure, but I assume it has something to do with dependencies.

Ariandr commented 5 years ago

@onmyway133 Because when I ran npm install, the package-lock.json got lots of changes, because you added node_modules to .gitignore. It can be a cause.

onmyway133 commented 5 years ago

@Ariandr Like last time, it runs fine with npm run start, but not when release đŸ˜ĸ

Ariandr commented 5 years ago

@onmyway133 Yeah, just npm start works okay, I checked it. But when release packaging is happening, it's the different story ☚ī¸

onmyway133 commented 5 years ago

@Ariandr Hi, it is because of apn being in devDependencies 🙄 , I just updated release https://github.com/onmyway133/PushNotifications/releases/tag/1.3.0, could you have another check ?

Ariandr commented 5 years ago

@onmyway133 Yes, sure)

Ariandr commented 5 years ago

@onmyway133 Seems to work fine, thanks)))

onmyway133 commented 5 years ago

@Ariandr đŸ•ē