onmyway133 / Smile

:smile: Emoji in Swift
https://onmyway133.com/apps/
Other
519 stars 45 forks source link

First fix for issue #10 #11

Closed Francescu closed 6 years ago

Francescu commented 6 years ago

Regarding issue #10

When I tried

XCTAssertEqual(Smile.extractEmojis(string: "Hello ⏰⌛️💳🆙."), "⏰⌛️💳🆙")

I got

XCTAssertEqual failed: ("⏰️💳🆙") is not equal to ("⏰⌛️💳🆙")

So only ⌛️ seems to bug for now.

I fixed adding 0x231B, which is ⌛️, in the list.

I also added the range 0x23F0...0x23FA

which at least includes

⏳ Hourglass Not Done | U+23F3
⏰ Alarm Clock | U+23F0
⏱️ Stopwatch | U+23F1, U+FE0F
⏲️ Timer Clock | U+23F2, U+FE0F
⏸️ Pause Button | U+23F8, U+FE0F
⏹️ Stop Button | U+23F9, U+FE0F
⏺️ Record Button | U+23FA, U+FE0F
onmyway133 commented 6 years ago

@Francescu Looks good to me. I think for complete list, we need to dump that list from iOS somehow