onmyway133 / Smile

:smile: Emoji in Swift
https://onmyway133.com/apps/
Other
519 stars 45 forks source link

Man Juggling ๐Ÿคนโ€โ™‚ from categories does not match emoji as man_juggling #13

Open joeboyscout04 opened 6 years ago

joeboyscout04 commented 6 years ago

There is a strange behavior where the man_juggling from the emojiCategories isn't recognized as an emoji using isEmoji and doesn't any values in the emojiList when I do a CTRL-F in Xcode, even though it's very clearly there in the emojiList if I look visually.

I'm not sure exactly what's wrong or how far it extends to other emoji, but it definitely seems like something isn't right.

joeboyscout04 commented 6 years ago

Looks like there are 48 emoji from the categories which don't match emojiList and then aren't recognized as emoji.

let allCategoryEmoji = emojiCategories.flatMap({ $0.value })
let nonEmojiCategoryEmoji = allCategoryEmoji.filter { return !isEmoji(character: $0)}
print(nonEmojiCategoryEmoji)
// result
["๐Ÿ‹๏ธ", "๐Ÿคผโ€โ™€๏ธ", "๐Ÿคผโ€โ™‚๏ธ", "๐Ÿคธโ€โ™€๏ธ", "๐Ÿคธโ€โ™‚๏ธ", "โ›น๏ธ", "๐Ÿคพโ€โ™€๏ธ", "๐Ÿคพโ€โ™‚๏ธ", "๐ŸŒ๏ธ", "๐Ÿ„โ€โ™€๏ธ", "๐ŸŠโ€โ™€๏ธ", "๐Ÿคฝโ€โ™€๏ธ", "๐Ÿคฝโ€โ™‚๏ธ", "๐Ÿšฃโ€โ™€๏ธ", "๐Ÿšดโ€โ™€๏ธ", "๐Ÿšตโ€โ™€๏ธ", "๐Ÿคนโ€โ™€๏ธ", "๐Ÿคนโ€โ™‚๏ธ", "๐Ÿ‘ฑโ€โ™€๏ธ", "๐Ÿ‘ณโ€โ™€๏ธ", "๐Ÿ‘ฎโ€โ™€๏ธ", "๐Ÿ‘ทโ€โ™€๏ธ", "๐Ÿ’‚โ€โ™€๏ธ", "๐Ÿ•ต๏ธ", "๐Ÿ‘ฉโ€โš•๏ธ", "๐Ÿ‘จโ€โš•๏ธ", "๐Ÿ‘ฉโ€โœˆ๏ธ", "๐Ÿ‘จโ€โœˆ๏ธ", "๐Ÿ‘ฉโ€โš–๏ธ", "๐Ÿ‘จโ€โš–๏ธ", "๐Ÿ™‡โ€โ™€๏ธ", "๐Ÿ’โ€โ™‚๏ธ", "๐Ÿ™…โ€โ™‚๏ธ", "๐Ÿ™†โ€โ™‚๏ธ", "๐Ÿ™‹โ€โ™‚๏ธ", "๐Ÿคฆโ€โ™€๏ธ", "๐Ÿคฆโ€โ™‚๏ธ", "๐Ÿคทโ€โ™€๏ธ", "๐Ÿคทโ€โ™‚๏ธ", "๐Ÿ™Žโ€โ™‚๏ธ", "๐Ÿ™โ€โ™‚๏ธ", "๐Ÿ’‡โ€โ™‚๏ธ", "๐Ÿ’†โ€โ™‚๏ธ", "๐Ÿ‘ฏโ€โ™‚๏ธ", "๐Ÿšถโ€โ™€๏ธ", "๐Ÿƒโ€โ™€๏ธ", "โ˜„๏ธ", "โŒš๏ธ"]
onmyway133 commented 6 years ago

@joeboyscout04 Hi, that's because those data are from different sources. I will try to find time to fix, but in the meantime PRs are welcome

joeboyscout04 commented 6 years ago

Sure. Which source is the canonical one, and how do you recommend to fix?