search

onmyway133 / Smile

:smile: Emoji in Swift
https://onmyway133.com/apps/
Other
519 stars 45 forks source link

.removeEmojis() is not working with newer emojis from the last ios update #3

Closed ServusJon closed 7 years ago

onmyway133 commented 7 years ago

@ServusJon Hi, you mean these emojis http://time.com/4598255/apple-ios-release-update-emoji/ ?

ServusJon commented 7 years ago

Yes 😊

Am 23.04.2017 um 17:10 schrieb Khoa Pham notifications@github.com:

@ServusJon Hi, you mean these emojis http://time.com/4598255/apple-ios-release-update-emoji/ ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ServusJon commented 7 years ago

Could you please add those to Smile? Would mean a lot to me!

onmyway133 commented 7 years ago

@ServusJon Hi, I will take a look

onmyway133 commented 7 years ago

@ServusJon Hi, I updated the tests https://github.com/onmyway133/Smile/commit/c387945e32d03875db662668a751e61f8b76e3a1 according to http://blog.emojipedia.org/ios-10-2-emoji-changelog/

Can you give me a test that fails?

ServusJon commented 7 years ago

thanks @onmyway133 but sadly a lot emoji weren't caught like that one: 🤑

Also the .removeEmojis function fails when there are emojis with different skin color.

onmyway133 commented 7 years ago

@ServusJon Hi, this 🤑 works. But removeEmojis does not handle emoji with skin tone. I just fixed it for you https://github.com/onmyway133/Smile/commit/7a92029ff085ee0283a9257bb0ebc653db01fb8d

How do you run your test? Can you give me the full list of emoji that does not work for you?

ServusJon commented 7 years ago

Don't really have a list but these seem get through. Some also with a gender symbol. I didn't test every emoji but I did some stress testing. Thank you so much for your effort!

bildschirmfoto 2017-05-13 um 20 39 20
onmyway133 commented 7 years ago

@ServusJon yeah, glad that it works for you 🎉 I will close this PR for now. Feel free to ping me if you have any ideas on improvement 😉

ServusJon commented 7 years ago

@onmyway133 these emojis that you see aren't affected by Smile. Could you please add them as well? Thank you!

onmyway133 commented 7 years ago

@ServusJon yeah, I will check for that

onmyway133 commented 7 years ago

@ServusJon Hi, I fixed it for you, you can checkout latest version on master. Note that you should use iOS or Chrome emojis, not macOS emojis. They are different https://github.com/onmyway133/Smile/commit/f6c6dd40f89273c1c726afb1e94fef73ea9d0b45

onmyway133 commented 7 years ago

@ServusJon Hi, I updated 1.1.1 https://github.com/onmyway133/Smile/releases/tag/1.1.1 which may fix your issues

ServusJon commented 7 years ago

Works like a charm! Thank you!

onmyway133 commented 7 years ago

Glad that it helps 🚀