search

onmyway133 / Smile

:smile: Emoji in Swift
https://onmyway133.com/apps/
Other
519 stars 45 forks source link

Question: What's required to update Smile to include latest iOS 11.1 emoji (vampire, mermaid, etc)? #5

Closed kharmabum closed 6 years ago

kharmabum commented 6 years ago

See: https://blog.emojipedia.org/ios-11-1-emoji-changelog/

kharmabum commented 6 years ago

@onmyway133 I went ahead and compiled a list of the new emoji with associated code points and aliases (I did my best to match the conventions already in Smile). https://gist.github.com/kharmabum/0dc6307a0bbccb8a76f93973db00abce

Francescu commented 6 years ago

@kharmabum does my PR #6 fixed the issue?

kharmabum commented 6 years ago

@Francescu I would say it's mostly sufficient. The lack of gendered versions of a few of the emoji is regrettable, but you may have had a compelling reason to leave those out.

Francescu commented 6 years ago

Iā€™m not aware of those. Could you list which variations are not working so I can try to fix?

kharmabum commented 6 years ago

@Francescu check out the gist I posted above.

Francescu commented 6 years ago

@kharmabum just tested some of the emojis in the gist (šŸ§™ā€ā™€ļøšŸ§™ā€ā™‚ļøšŸ§›ā€ā™€ļøšŸ§›ā€ā™‚ļø) and they're working fine with Smile. Please not that while some gendered emojis are not present in Emoji.swift they'll work. Feel free to test and do a quick list here of non-working gendered emojis while Smile.

Thanks for your help šŸ˜Š

kharmabum commented 6 years ago

šŸ™šŸ‘

@kharmabumhttps://github.com/kharmabum just tested some of the emojis in the gist (šŸ§™ā€ā™€ļøšŸ§™ā€ā™‚ļøšŸ§›ā€ā™€ļøšŸ§›ā€ā™‚ļø) and they're working fine with Smile. Please not that while some gendered emojis are not present in Emoji.swifthttps://github.com/onmyway133/Smile/pull/6/files#diff-2c35896e4293616d55c97d6f56515bbaR1449 they'll work. Feel free to test and do a quick list here of non-working gendered emojis while Smile.

Thanks for your help šŸ˜Š

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/onmyway133/Smile/issues/5#issuecomment-368591391, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAv0xdUVnmpe4qDgD_96AZiOPSTTZ-Mtks5tYvErgaJpZM4QvV-g.

onmyway133 commented 6 years ago

@Francescu @kharmabum Thanks for your contribution ā¤ļø If you 'd like to be make more changes, I 'd be very happy to add you as contributors to the project