search

onmyway133 / Smile

:smile: Emoji in Swift
https://onmyway133.com/apps/
Other
519 stars 45 forks source link

Make ⌚️ working #8

Closed Francescu closed 6 years ago

Francescu commented 6 years ago

It makes the ⌚️ emoji working.

Basically I found a deeper issue with Script/parser.js I think we should clean the item.emoji in the parse function.

When I tried to flatten the item watch in emojiList I got ["⌚️", ""] instead of just ["⌚️"].

So I manually fixed this one + added in the unicode list().

I'll do a check on all emojis when I have some time.

Let me know if somebody can handle the parser.js modification.

onmyway133 commented 6 years ago

@Francescu Hi, thanks for the PR 👍 I will try checking the this emoji code to see if it behaves specifically.

Really like your contributions, do you want to be contributor in this project ? ❤️

Francescu commented 6 years ago

Thanks, it will be my honor 😄 👏

onmyway133 commented 6 years ago

@Francescu Cool, you have been added. Let's keep this awesome 😎

Francescu commented 6 years ago

@onmyway133 Thanks 🙇 , I'll continue to do PR so we always get reviewed code 😎