search

onnela-lab / beiwe-android

Beiwe is a smartphone-based digital phenotyping research platform. This is the Beiwe Android app code. The Beiwe2 app is also available on the Google Play store to use with open source builds of the Beiwe backend.
https://www.beiwe.org/
BSD 3-Clause "New" or "Revised" License
26 stars 16 forks source link

Allow numbers between 8 and 15 characters/localizations for German/Italian #61

Closed clementzach closed 1 year ago

clementzach commented 2 years ago

This PR sets a min and max number for phone numbers rather than requiring them to be at least 15 characters long.

I also added localization files for German and Italian.

The app worked correctly on the Android emulator on my machine, and researchers haven't had issues with the screenshots I've sent them.

clementzach commented 2 years ago

@zagorsky, I talked with @kwcarlso and she said that our lab would love to have you merge this PR and deploy a new version of the app.

These changes need to go to the version of the app hosted at http://eu.beiwe.org/download in particular, because that is the deployment that study participants using these features will use to download the app.

biblicabeebli commented 2 years ago

@zagorsky I see no reason not to merge this in. I've checked and there are no conflicts with the jz/messaging branch, is there localization work on that that will need to be added?

clementzach commented 2 years ago

I believe that it would be better for us to merge this now and have non-localized messaging text than to wait until the messaging feature is done to localize this. The German team hopes to start recruiting in the next week or so, and it would be nice for them to be able to have a localized version of the app from the get-go