updating a survey resets (at least) absolute survey schedules

[biblicabeebli]

a new survey notification will then be sent from the backend whenever you update a survey.

my specific test case that triggered this involved updating a survey question prompt.

[biblicabeebli]

Hassan probably just got this bug occurring on a weekly survey. hmmm

[hydawo]

Hi Eli,

On our studies server, I'm enrolled as a beta tester in the "Nationwide - Lu - IBS Digital Phenotype" (Study ID: f7XyBE8mkViD4en4yHygMLqa) study with Beiwe ID if9qyadp

This study was initially set up to send:

• Weekly survey on Saturdays at 12PM
• Monthly survey at 5, 30, 60, and 90 days relative to enrollment date

Attached is a screenshot of the push notification history for this ID.

On the first Saturday (3/9/24) of testing, I correctly received the Weekly survey at 12PM. On the following Wednesday (3/13/24), I received 3 notifications:

• 2 x weekly survey notification → based on the survey history .JSON (attached), the study team changed this survey at ~4:53PM on 3/13/24 → I believe this is the bug you mentioned above
• 1 x monthly survey notification → this functions correctly

f7XyBE8mkViD4en4yHygMLqa_surveys_history_data.json

[biblicabeebli]

(wow this issue got buried)

Will review. This was not a detail I reviewed in my push notification review: https://github.com/onnela-lab/beiwe-backend/issues/402

I'm going to make no guesses at this time about why this happens except to say that the ScheduledEvent creation checks for historical events that align perfectly, so if anything changed with the strict "canonical survey time", which is carefully recorded in the notification history, those surveys should be resent.

Currently, generating ScheduledEvents creates events in the past, which will ~immediately be sent out. We discussed changing this for absolute schedules, this consideration should be added to 402.