onnowhere / youtube_music_playlist_downloader

YouTube Music Playlist Downloader
MIT License
129 stars 9 forks source link

Metadata enhancements (also fixes #2) #5

Closed MrAn0nym closed 2 years ago

MrAn0nym commented 2 years ago
onnowhere commented 2 years ago

I currently kept all songs using the playlist title as the album as an intentional choice, so that your songs are listed under one collection in apps. Additionally, pulling the artist name from artist often pulls no name and sometimes the wrong name (for example, in some song covers, it can list the original artist instead of the cover artist).

Trying out the change, it fails to update metadata with reason 'Unable to download video: Invalid MultiSpec data: None' from line 199, because album and/or artist isn't present on all videos. Possible modification could be to default to uploader if there is no artist, and for album perhaps just no text?

If you do want to pursue these two modifications (uploader and album), I think it would be better to have them as additional options instead, as both of these fields in their current setup were intentional based on my own usage with different playlists.

MrAn0nym commented 2 years ago

Apologies for the late responses and rushed commit last time, was quite busy with school ^^

Feel free to squash the commits when merging, just leaving them as they are rn to better point out the changes

onnowhere commented 2 years ago

No worries there isn't really any rush 👍