search

onnx / models

A collection of pre-trained, state-of-the-art models in the ONNX format
http://onnx.ai/models/
Apache License 2.0
7.93k stars 1.4k forks source link

Can we have newer opset of bidaf-9 model (including opset 9 or newer onnx.Scan op)? #540

Closed negiyas closed 1 year ago

negiyas commented 2 years ago

Model Request

Which model would you like to see in the model zoo?

text/machine_comprehension/bidirectional_attention_flow/model/bidaf-9.onnx

Describe why newer opset of this model is relevant

The model's opset is 9, but onnx.Scan op's opset should be 8, because it has the batch size dim in the onnx.Scan op. Opset-8 of onnx.Scan op suports the batch size, but opset-9 (or newer) of onnx.Scan op does not support the batch size dim, so that this model cannot be compiled with the onnx-mlir compiler (https://github.com/onnx/onnx-mlir/) supporting opset 9, 11 and 13 of onnx.Scan op.

image

negiyas commented 1 year ago

Closing this issue, because it is supported by onnx-mlir.