search

onnx / onnx-caffe2

Caffe2 implementation of Open Neural Network Exchange (ONNX)
Other
165 stars 66 forks source link

Bidirectional elman RNN conversion to Caffe2 #198

Closed anderspapitto closed 6 years ago

anderspapitto commented 6 years ago

tied to https://github.com/pytorch/pytorch/pull/5120

anderspapitto commented 6 years ago

yeah, it doesn't look pretty, but unfortunately this much slicing/concatenation is required by the differing semantics of onnx/caffe2. It might be possible to share more code between the three cases in a future refactor, though

anderspapitto commented 6 years ago

@dzhulgakov actually I'd like to land this diff first (once tests pass), because the pytorch diff depends on this one (the pytorch diff requires that onnx-caffe2 understand the direction argument)

anderspapitto commented 6 years ago

@onnxbot retest this please