onnx / onnx-mlir

Representation and Reference Lowering of ONNX Models in MLIR Compiler Infrastructure
Apache License 2.0
742 stars 315 forks source link

Undefined datatype for attribute when importing ONNX 1.0 MNIST model #41

Open aaronsm opened 4 years ago

aaronsm commented 4 years ago

What version of ONNX is supported?

I tried onnx-mlir with the ONNX 1.0 MNIST model from here [1]. It looks like every node has an undefined datatype which seems wrong and crashes the tool. If I use the ONNX 1.2 MNIST model from the same website the tool works.

$ ./onnx-mlir --EmitONNXIR mnist/model.onnx -debug

ImportNode=Constant 'value' undefined Assertion failed: (false && "datatype for attribute is not implemented"), function convertAttributeProtoToNameValuePair, file /onnx-mlir/src/Builder/FrontendDialectTransformer.cpp, line 227.

[1] https://github.com/onnx/models/tree/master/vision/classification/mnist

tjingrant commented 4 years ago

@aaronsm our current opset version support policy has been somewhat vague, the clarification of which is a work item near the top of our todo list.

We currently support only the latest opset version, and we plan to expand the scope of our support imminently. Will keep you posted on this thread.

tungld commented 4 years ago

Hi @aaronsm, FYI, this ONNX MNIST model opset v8, https://onnxzoo.blob.core.windows.net/models/opset_8/mnist/mnist.tar.gz, works well in the current onnx-mlir.