search

onnx / onnx-tensorflow

Tensorflow Backend for ONNX
Other
1.27k stars 296 forks source link

resolve #1020 squeeze and unsqueeze opset v13 #1022

Closed krishnanNuance closed 2 years ago

krishnanNuance commented 2 years ago

Work contains implementation for squeeze and unsqueeze for opset version 13

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

chinhuang007 commented 2 years ago

@krishnanNuance Thanks for providing the fix! Please sign the CLA.

krishnanNuance commented 2 years ago

I not able to find the test case starting with 'test_sequencemap' in test_onnx_backend.py. In local setup, currently all cpu tests are passing. Not able to reproduce the failure testcase.

krishnanNuance commented 2 years ago

I not able to find the test case starting with 'test_sequencemap' in test_onnx_backend.py. In local setup, currently all cpu tests are passing. Not able to reproduce the failure testcase.

@chinhuang007 Can you please guide me to reproduce this test scenario? Not able to do so using the commands -Install dependencies and ONNX development stage.

chudegao commented 2 years ago

@krishnanNuance The test case is from onnx master branch. To reproduce it you need install onnx from source code following https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py You can update https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py to exclude new added test case.

krishnanNuance commented 2 years ago

@krishnanNuance The test case is from onnx master branch. To reproduce it you need install onnx from source code following https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py You can update https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py to exclude new added test case.

Thank you @chudegao . I have excluded the testcase and opened the ticket - https://github.com/onnx/onnx-tensorflow/issues/1027 to track the issue.