Add sign to idempotent ops list

onnx / optimizer

Actively maintained ONNX Optimizer

Apache License 2.0

647 stars 90 forks source link

Add sign to idempotent ops list #139

Open ananyamukh6 opened 1 year ago

ananyamukh6 commented 1 year ago

Sign op is idempotent, so adding it to eliminate_consecutive_idempotent_ops pass

daquexian commented 1 year ago

LGTM, thanks!

ananyamukh6 commented 1 year ago

@daquexian , the tests seemsed to have failed because of flake8. I pused a patch fixing the flake8 errors. Is there any other style checks to be run (like say for the cpp code)?