search

onnx / optimizer

Actively maintained ONNX Optimizer
Apache License 2.0
650 stars 90 forks source link

where-not optimization #140

Open ananyamukh6 opened 1 year ago

ananyamukh6 commented 1 year ago

// where(not(b), x, y) -> where(b, y, x) // https://github.com/microsoft/onnxruntime/blob/v1.15.1/onnxruntime/core/optimizer/not_where_fusion.h

daquexian commented 1 year ago

LGTM, thanks!

ananyamukh6 commented 1 year ago

@daquexian , the tests seemsed to have failed because of flake8. I pused a patch fixing the flake8 errors. Is there any other style checks to be run (like say for the cpp code)?

daquexian commented 1 year ago

@daquexian , the tests seemsed to have failed because of flake8. I pused a patch fixing the flake8 errors. Is there any other style checks to be run (like say for the cpp code)?

I think not (if memory serves). BTW, it seems that you need to sign the DCO again.

ananyamukh6 commented 1 year ago

@daquexian , Added the DCO sign off