search

onnx / sigs

Repository for ONNX SIG artifacts
Apache License 2.0
19 stars 34 forks source link

Add Yuan Yao to op sig approvers #154

Closed gramalingam closed 1 year ago

gramalingam commented 1 year ago

I suggest that Yuan Yao be added to the operator SIG approver list. He has been contributing to the ONNX spec regularly, and will also be the release manager for the upcoming ONNX release.

gramalingam commented 1 year ago

LGTM

quick question: does an approver name need to be both on the general list AND the approver or it is sufficient to be only on the approver list (as it presumably grants more rights).

I see many names in approver list not in general list. So, I assume that is not required.

gramalingam commented 1 year ago

If I understand correctly, some steering-committee member will need to update the permission, and then merge this PR in?

andife commented 1 year ago

As a onnx member one can also request the addition to the github list also directly at: https://github.com/orgs/onnx/teams/sig-operators/members? I do not know if this is practical? (or any help for the person with admin rights to the github repo)