search

onnx / tensorflow-onnx

Convert TensorFlow, Keras, Tensorflow.js and Tflite models to ONNX
Apache License 2.0
2.33k stars 432 forks source link

Support for tensorflowjs 3.17 -- maxNumElements attr in TensorListReserve dynamic list shoule be ignored #1943

Open hwangdeyu opened 2 years ago

hwangdeyu commented 2 years ago

5 tests are failed with latest tfjs vesion 3.17, which have skiped so far. Need to support it in the future.

https://github.com/onnx/tensorflow-onnx/blob/772dbe605e94880d4cbf8e9e1ed9ce9517b89c64/tests/test_cond.py#L121

https://github.com/onnx/tensorflow-onnx/blob/772dbe605e94880d4cbf8e9e1ed9ce9517b89c64/tests/test_loops.py#L69

https://github.com/onnx/tensorflow-onnx/blob/772dbe605e94880d4cbf8e9e1ed9ce9517b89c64/tests/test_loops.py#L162

https://github.com/onnx/tensorflow-onnx/blob/772dbe605e94880d4cbf8e9e1ed9ce9517b89c64/tests/test_loops.py#L186

https://github.com/onnx/tensorflow-onnx/blob/772dbe605e94880d4cbf8e9e1ed9ce9517b89c64/tests/test_loops.py#L224

hwangdeyu commented 2 years ago

Created an issue https://github.com/tensorflow/tfjs/issues/6487.

hwangdeyu commented 2 years ago

Created an issue tensorflow/tfjs#6487.

tfjs community fixed this issue by https://github.com/tensorflow/tfjs/pull/6523. Wait for a new release to support it.

hwangdeyu commented 2 years ago

Mark related issue https://github.com/tensorflow/tfjs/issues/6748.