search

onnx / tutorials

Tutorials for creating and using ONNX models
Apache License 2.0
3.34k stars 626 forks source link

dianna package: eXplainable AI for ONNX models (XAI4ONNX) #291

Closed elboyran closed 2 months ago

elboyran commented 2 months ago

Description

Motivation and Context

elboyran commented 2 months ago

Indicating Ramakrishnan Sivakumar and Javier Martinez as reviewers as advised in the Slack thread.

ramkrishna2910 commented 2 months ago

Looks good to me. Please wait for @javier-intel to approve as well.

elboyran commented 2 months ago

@ramkrishna2910 and @javier-intel thank you for the approval. I do not have write access to be able to merge the PR.

andife commented 2 months ago

I wonder if the urls should be improved? At least some checks fail.

elboyran commented 2 months ago

I will try to fix those. (All checks were passing when I first submitted the PR.)

elboyran commented 2 months ago

@andife, @ramkrishna2910, @javier-intel I see now the previously failing workflow is expecting approval.

javier-intel commented 2 months ago

Hi @elboyran there still appear to be a couple of failures in the last log. Were this the same or are they new ones?

elboyran commented 2 months ago

Hi @elboyran there still appear to be a couple of failures in the last log. Were this the same or are they new ones?

Some are the same, but it's hard for me to judge which are considered insecure URLs. I removed some I thought they might be. Some URL checks still fail without pointing to specific ones. Shall I remove all then (they are pointing to data and papers to explainers)?

Please, note that some checks fail not from my tutorial, but from the repo's README.md (which I modified only with a link to my tutorial).

elboyran commented 2 months ago

Hi @javier-intel , I have removed the links. If it fails again, I hope it is not due to my notebook. [Some links failed before in the README, not from my edits.]

javier-intel commented 2 months ago

There are 3 issues flagged by the validation tool. Those are in the main branch and unrelated to your changes so they shouldn't block the PR. I'll merge the changes and fix the 404 flagged by the tool separately at a later time.

elboyran commented 2 months ago

[celebrate] Elena Ranguelova reacted to your message:

From: Javier Martinez @.> Sent: Monday, July 15, 2024 1:13:11 PM To: onnx/tutorials @.> Cc: Elena Ranguelova @.>; Mention @.> Subject: Re: [onnx/tutorials] dianna package: eXplainable AI for ONNX models (XAI4ONNX) (PR #291)

Merged #291https://github.com/onnx/tutorials/pull/291 into main.

— Reply to this email directly, view it on GitHubhttps://github.com/onnx/tutorials/pull/291#event-13505419005, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAYYBWPRIIR4PNEJRK2YP6DZMPDGPAVCNFSM6AAAAABJVRF7FKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGUYDKNBRHEYDANI. You are receiving this because you were mentioned.Message ID: @.***>