search

onomojo / i18n-timezones

Rails I18n timezone translations
MIT License
67 stars 47 forks source link

Arabic translation added #9

Closed likhon closed 10 years ago

likhon commented 11 years ago

Arabic translation file added

onomojo commented 11 years ago

Thanks for the contribution and I apologize for the incredibly long delay in my response. Regarding this pull request, you should normally try to rebase your commits down to a single commit before you submit a pull request. This way when someone looks through the logs they can more easily see what changes were made, by who, and when. You have 3 commits here so if I merged it as is all those commits will go into the master branch and make it a little harder to backtrack to find out what was actually changed. Here's my notes on rebasing to squish your commits into one before a pull request if you're interested:

To squish commits:

  1. git log
  2. count the number of YOUR commits from the head that you want to squish into one. Lets assume there are 15 commits from the head
  3. git rebase -i HEAD~15
  4. change the bottom 14 commits to squish (just change 'pick' to 's') and leave the top commit as pick
  5. Fix any conflicts as you would normally
  6. git add - NOTE: on this step never do a git commit -m ""... just a "git add"
  7. git rebase --continue
  8. if there are more conflicts, it will let you know again.. and you will be on step 5 to 8 again
  9. if you did 7 and there are no more conflicts. you have finished
  10. git push origin yourbranchname --force

After you're done rebasing, then you create a pull request. Since you already have this pull request open, after you finish step 10, it ought to just say 1 commit when you view the pull request.

onomojo commented 10 years ago

Thanks for this. I merged anyway and bumped versions.