search

onomondo / nrf-softsim

Manifest repo for integrating SoftSIM and nrf-sdk
30 stars 6 forks source link

feat: make asserts Zephyr compatible #12

Closed MirkoCovizzi closed 11 months ago

MirkoCovizzi commented 11 months ago

This commit updates asserts to be compatible with Zephyr.

MirkoCovizzi commented 11 months ago

Thanks Mirko! I'm actually considering dropping them completely... Don't think they add anything. I'll look into making it fail gracefully with a helpful err. message instead.

Hi Peter, I updated the commit. I think updating the asserts with __ASSERT_NO_MSG is a better way. __ASSERT_NO_MSG is the proper Zephyr way to assert. They have their own Kconfig, they are disabled by default and if a user wants to enable them they jsut need to use CONFIG_ASSERT=y.

We had problems building NCS samples, hence the commit.

MirkoCovizzi commented 11 months ago

@peterbornerup Is there any update on this? This issue needs to be addressed as soon as possible because it breaks compatibility with NCS samples. Currently master doesn't compile out of the box with NCS 2.5.0.

Edit: Adding CONFIG_NEWLIB_LIBC=y to the project configuration fixes the build issue, however there is still a case to be made for Zephyr's universal asserts.