onomondo / nrf-softsim

Manifest repo for integrating SoftSIM and nrf-sdk
30 stars 6 forks source link

Namespace problems #15

Closed JordanYates closed 4 months ago

JordanYates commented 11 months ago

There are several examples of functions that are not properly namespaced to this repo, which are almost certain to cause issues for someone in the future with an ecosystem as large as Zephyrs'. By this, I mean the name is so generic that other libraries and application could easily write code with the same name.

In the same vein, there are a few internal variables without a static qualifier which could cause compilation issues for users.

Namespace issues:

Static issues:

peterbornerup commented 11 months ago

Thanks for addressing these issues. I've opened a ticket internally.