onomyprotocol / arc

Arc moves assets cross-chain to and from integrated blockchains.
Apache License 2.0
3 stars 10 forks source link

Return errors instead of exit() call for orchestrator #59

Closed dzmitryhil closed 2 years ago

dzmitryhil commented 2 years ago

Resolves #37 Resolves #42

leviathanbeak commented 2 years ago

generally code is fine, but my intention for GravityError::UnrecoverableError was mainly for stuff that would stop the orchestrator (especially at the start, ie UnrecoverableError("Invalid Config"))

so if all of your errors would stop it then that is the appropriate field of Enum, if not, let's use another one