onosproject / onos-cli

Command-line interface for ONOS (µONOS Architecture)
Apache License 2.0
18 stars 29 forks source link

Running command "onos topo get devices -" crashes onos-topo #10

Closed SeanCondon closed 5 years ago

SeanCondon commented 5 years ago

I entered this command by mistake - I intended it to end in -v

~ $ onos topo get devices -
Error: rpc error: code = Unavailable desc = transport is closing
~ $

Fair enough - it was an invalid entry but you'd think the CLI would not let it through. onos topo get devices -v works fine

When watching the state of the pods I can see onos-topo restart

^Cscondon@Z420:~$ kubectl get pods -n onit-1 -w
NAME                                READY   STATUS    RESTARTS   AGE
atomix-controller-fb857b477-7pwhm   1/1     Running   0          27m
device1                             1/1     Running   0          17m
device2                             1/1     Running   0          2m39s
onos-cli-c5b4c7f5f-d68kf            1/1     Running   0          26m
onos-config-6cfdc589ff-dqwvs        1/1     Running   0          26m
onos-config-envoy-56bf9486-j5dkd    1/1     Running   0          26m
onos-gui-866b488884-grpvv           1/1     Running   0          26m
onos-topo-7cfc8f7486-s4s2q          1/1     Running   1          27m
onos-topo-envoy-7778bc79dd-9j9qv    1/1     Running   0          27m
raft-1-0                            1/1     Running   0          27m
onos-topo-7cfc8f7486-s4s2q          0/1     Error     1          28m
onos-topo-7cfc8f7486-s4s2q          0/1     CrashLoopBackOff   1          28m
onos-topo-7cfc8f7486-s4s2q          0/1     Running            2          29m
onos-topo-7cfc8f7486-s4s2q          1/1     Running            2          29m
SeanCondon commented 5 years ago

See also https://github.com/onosproject/onos-config/issues/639 which is revealed as a side effect of this

kuujo commented 5 years ago

This should be in onosproject/onos-topo

kuujo commented 5 years ago

I will test this issue against https://github.com/onosproject/onos-topo/pull/29 though

kuujo commented 5 years ago

Fixed anyways ☝️

SeanCondon commented 5 years ago

thanks