Introduce type check and returning in gNMI subscribe NB

onosproject / onos-config

Configuration subsystem for ONOS (µONOS Architecture)

45 stars 56 forks source link

Introduce type check and returning in gNMI subscribe NB #493

Closed Andrea-Campanella closed 5 years ago

Andrea-Campanella commented 5 years ago

Is your feature request related to a problem? Please describe. Currently gNMI subscribe on the NB does not include type checking and return everything as a Json file/string val See line 215 of subscribe.go Describe the solution you'd like Subscribe.go needs to be extended in order to include those testing and verification in order to return the proper object type to the client.

Andrea-Campanella commented 5 years ago

Check must be done on SubscriptionList at line 44 in Subscribe.go

Andrea-Campanella commented 5 years ago

@SeanCondon is this done ?

SeanCondon commented 5 years ago

I think it is but am going to keep it open until I can prove it in an integration test