onramper / small-open-datasets

A collection of automatically-updated, ready-to-use and open-licensed datasets
MIT License
35 stars 3 forks source link

Still being updated? #25

Open flanfly opened 8 months ago

flanfly commented 8 months ago

Hi. Cool project, but the latest release NPM is 2 years old now and lots of more recent cryptocurrencies are missing. Is this project still maintained?

fernandogong commented 7 months ago

I downloaded the project locally to update the cryptocurrencies and upload it as a library for me to use. However, when I ran npm run generate, it returned the following error:

throw new Error(“Page " + page + " triggered two consecutive errors, aborting”); ^ Error: Page 1 triggered two consecutive errors, aborting

My question is: because the project has not had code updates in the last 4 years, has the coingecko endpoint changed? This doubt arose after analyzing the code in this specific part in base64-cryptocurrencies-icons/build.ts:

const coins = await fetch(https://api.coingecko.com/api/v3/coins?page=${page}).then(res => res.json()) as {

Where the url used is “https://api.coingecko.com/api/v3/coins?page=” and the page is a number that will start from 1 up to the maxPages previously defined in the code.

However, when accessing an example endpoint “https://api.coingecko.com/api/v3/coins?page=1”, the API returned the following response: { “error”: “Incorrect path. Please check https://www.coingecko.com/api/” }

Which also led me to another question if, to use this endpoint I would have to put my API Key somewhere.