onsails / lspkind.nvim

vscode-like pictograms for neovim lsp completion items
MIT License
1.51k stars 39 forks source link

Fix codicon vertical alignment #56

Open mskelton opened 2 years ago

mskelton commented 2 years ago

Appreciate the work you've done on this plugin, really adds some nice UI touches to completions in nvim!

One thing that bothered me about the codicons preset is that the line height was off a bit causing the icons to be offset vertically and not centered properly with the text. It's not a bug with this plugin, more of a result of how the codeicons font is built.

I forked the codicons repo and modified the font generation to add some descent to the icons so that it would cause them to align properly. You can view my fork here: https://github.com/microsoft/vscode-codicons/compare/main...mskelton:vscode-codicons:main.

I'm posting this issue more for others in the future if they want this improvement, as I don't see anything actionable unless you would like me to add some notes to the readme. Totally up to you.

Here is the result before and after (it's minor, but noticeable 🙂 )

Before

image

After

image