feat: allow MustPassRepeatedly decorator to be set at suite level

onsi / ginkgo

A Modern Testing Framework for Go

http://onsi.github.io/ginkgo/

MIT License

8.22k stars 650 forks source link

Closed maxcleme closed 1 year ago

maxcleme commented 1 year ago

Aims to allow MustPassRepeatedly to be set at suite level programatically, similarly of FlakeAttempts.

maxcleme commented 1 year ago

Regarding the test, I'm not sure which way I should go

either add a new cases in integration/_fixtures/decorations_fixture/flaky_repeated/flaky_repeated_fixture_suite_test.go, using suite config instead of node decorator
edit integration/_fixtures/config_override_fixture/config_override_fixture_suite_test.go (which seems relevant?)
same as internal/internal_integration/config_flake_attempts_test.go ?

@onsi any thoughts? 😁

onsi commented 1 year ago

i’ll try to take a closer look today but to unblock you:

i’d definitely like an internal integration test - and it would be good to ensure that the override at the suite level plays nicely with any per-test values (happy to think through what the behavior should be with you. at first blush i’d say it should do whatever FlakeAttempts does.)
the outside-in integration test is less crucial. one of the two you point out should be enough

maxcleme commented 1 year ago

@onsi I've added some tests, let me know what you think!

onsi commented 1 year ago

i just cut a release with this in it, thanks!