onsi / ginkgo

A Modern Testing Framework for Go
http://onsi.github.io/ginkgo/
MIT License
8.12k stars 644 forks source link

Fix typo in internal/suite.go #1332

Closed shubham14bajpai closed 6 months ago

shubham14bajpai commented 6 months ago

I saw this error message with a small spelling mistake while writing tests.

cnanot clone suite after tree has been built

This PR fixes the same.

blgm commented 6 months ago

Thank you @shubham14bajpai. This is a good improvement, but unfortunately the tests fail because they are expecting the typo!

  [FAILED] Expected
      <*errors.errorString | 0xc0002a81f0>: 
      cannot clone suite after tree has been built
      {
          s: "cannot clone suite after tree has been built",
      }
  to match error
      <string>: cnanot clone suite after tree has been built
  In [It] at: /home/runner/work/ginkgo/ginkgo/internal/suite_test.go:91 @ 01/05/24 11:01:59.47

Do you want to update the test too? If you don't have the time then I'm happy to do it, but wanted to give you the choice.

shubham14bajpai commented 6 months ago

Thank you @shubham14bajpai. This is a good improvement, but unfortunately the tests fail because they are expecting the typo!

  [FAILED] Expected
      <*errors.errorString | 0xc0002a81f0>: 
      cannot clone suite after tree has been built
      {
          s: "cannot clone suite after tree has been built",
      }
  to match error
      <string>: cnanot clone suite after tree has been built
  In [It] at: /home/runner/work/ginkgo/ginkgo/internal/suite_test.go:91 @ 01/05/24 11:01:59.47

Do you want to update the test too? If you don't have the time then I'm happy to do it, but wanted to give you the choice.

Sure I will update the test as well 👍

blgm commented 6 months ago

Thanks @shubham14bajpai!