onsi / ginkgo

A Modern Testing Framework for Go
http://onsi.github.io/ginkgo/
MIT License
8.12k stars 644 forks source link

Add GinkgoTB() function #1333

Closed ebabani closed 6 months ago

ebabani commented 6 months ago

This function returns a wrapper around GinkgoT() which satisfies the testing.TB interface.

onsi commented 6 months ago

thanks! this looks great - but I think there’s a bug in the (previous, existing) test that checks that all definitions in the core DSL are exported in the modular DSL package (long story….). I’ll take a look later today/tomorrow and fix it.

ebabani commented 6 months ago

thanks! this looks great - but I think there’s a bug in the (previous, existing) test that checks that all definitions in the core DSL are exported in the modular DSL package (long story….). I’ll take a look later today/tomorrow and fix it.

I pushed a fix for that failure. Forgot to run those tests and was only running integration tests.

I updated the symbol check to ignore functions with a receiver. Those methods are never going to cause an import conflict, and I added the missing package level functions and types to core_dsl.go.

onsi commented 6 months ago

fantastic, thank you! i’ll cut a release soon :)