search

onsi / ginkgo

A Modern Testing Framework for Go
http://onsi.github.io/ginkgo/
MIT License
8.4k stars 660 forks source link

Ginkgo v2 CLI breaks when v1 is used #1346

Open steve-hb opened 10 months ago

steve-hb commented 10 months ago

When setting up new projects, Goland (IntelliJ IDEA) imports the v1 by default. This always causes headaches in my team due to the incompatibility of various flags (or passing them to the library used by the project) and therefore wastes times until someone figures out the old version was used and just upgrades every reference to /v2.

Proposal: Reject or at least warn the user when v1 was used in the project.

onsi commented 10 months ago

hey @steve-hb - this makes sense to add to the v2 cli. though it's gonna be a bit before I can get to it. are you up for working on a PR if I point you at the right places?

also have you opened an issue over with the IntelliJ folks. I bet this is generic issue with versioned go modules where the ide has no idea which version you want (I wonder if there's a way to tell it "always use v2").

steve-hb commented 9 months ago

When I find the time, I may be able to do it, but next weeks I'm not available.

I'll create a ticket with IntelliJ folks, didn't think of that tbh.